refactor: Added possibility to use the GithubAPI. #813
Conversation
… any page, to list as example our repositories.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 8476440 | Triggered | Generic Password | 8e92815 | src/Moonglade.Web/Controllers/SettingsController.cs | View secret |
| 8476440 | Triggered | Generic Password | d8e0d93 | src/Moonglade.Web/Controllers/SettingsController.cs | View secret |
| 8476440 | Triggered | Generic Password | d8e0d93 | src/Moonglade.Web/Controllers/SettingsController.cs | View secret |
| 8476440 | Triggered | Generic Password | 8e92815 | src/Moonglade.Web/Controllers/SettingsController.cs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
@EdiWang maybe we could use |
|
@WeihanLi Thanks for your comment. I haven't noticed, that Mads Kristensens "Code Cleanup on Save" was enabled. I used dotnet format on my last PR. So it should be better. |
|
This design is providing fixed number of third party links. A better approach is to let user add any number of links with icons they want. So providing a UI with a JSON editor would be better, since Moonglade users are all developers. Just like how the "Custom menus" is designed.
|
|
@EdiWang I think that would be the best option. Maybe we can provide some predefined tags for that. Maybe the user creates a new link and set a provider tag, what can be "Linkedin" or "Facebook". So wen can ensure, that we can find a specific entry by its provider name. I will look at your code for the menu. |
|
Close as tracked by #831 |
This Pull Request enables a option to access the Github Api. Currently implemented is the request for Repositories from the user.
Users Full path to Github Profile is saved into SocialProfileSettings. Also there are a possibility to add some other Social Profile Links. So they can used into custom pages.